New pr to update MailKit, ideally replacing #8746 #8768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienros
reviewed
Mar 7, 2024
| @@ -116,7 +106,11 @@ public class SmtpMessageChannel : Component, ISmtpChannel, IDisposable { | |||
| mailMessage.ReplyTo.AddRange(ParseRecipients(emailMessage.ReplyTo)); | |||
| } | |||
|
|
|||
| _smtpClientField.Value.Send(mailMessage); | |||
| using (var smtpClient = CreateSmtpClient()) { | |||
There was a problem hiding this comment.
Might be worth having an overload which takes multiple emails to reuse the client, otherwise bulk-sending them will create as many connections.
sebastienros
approved these changes
Mar 7, 2024
|
Please merge the latest 1.10.x to fix the build error. |
|
@AndreaPiovanelli @MatteoPiovanelli-Laser would you like to continue working on this or #8746? |
# Conflicts: # src/Orchard.Web/Modules/Orchard.Email/packages.config
MatteoPiovanelli-Laser
force-pushed
the
mailkit_upgrade_fix
branch
from
07c0e64
to
1f92bd0
Compare
|
I've rebased this one as well. At this point I'm just hoping either of the PRs passes github's checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should replace #8746 starting from the up-to-date 1.10.x branch.