Simplify the Azure Search AI events and centralize setting the FullIndexName #17596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
OrchardCore.Search.AzureAImodule, focusing on improving index creation and settings management, as well as adding support for recipe execution steps. The most important changes include modifying the index settings service methods, updating logging messages, and introducing new service classes and handlers.Improvements to Index Settings Management:
src/OrchardCore.Modules/OrchardCore.Search.AzureAI/Controllers/AdminController.cs: ReplacedSetMappingsAsyncwithCreateAsyncand updated logging to usesettings.IndexFullName. [1] [2] [3] [4] [5]Addition of Recipe Execution Steps:
src/OrchardCore.Modules/OrchardCore.Search.AzureAI/Startup.cs: AddedRecipeStartupclass to register recipe execution steps for rebuilding, resetting, and setting up Azure AI search indexes.Refactoring and Code Simplification:
src/OrchardCore/OrchardCore.Search.AzureAI.Core/Handlers/ContentAzureAISearchIndexHandler.cs: RefactoredMappingAsyncmethod toSetMappingAsyncand introducedCanHandlemethod for checking index source. [1] [2] [3] [4] [5] [6] [7]New Service Classes and Handlers:
src/OrchardCore/OrchardCore.Search.AzureAI.Core/Handlers/AzureAISearchIndexHandler.cs: AddedAzureAISearchIndexNameServicefor generating full index names and implementedCreatingAsyncmethod.Removal of Deprecated Methods:
src/OrchardCore/OrchardCore.Search.AzureAI.Core/Models/AzureAISearchIndexSettingsUpdatedContext.cs,src/OrchardCore/OrchardCore.Search.AzureAI.Core/Models/AzureAISearchMappingContext.cs: Removed deprecated context classes. [1] [2]