Skip to content

Conversation

@Tales-K
Copy link

@Tales-K Tales-K commented Oct 29, 2025

  • aloof-sort-by: handle nils and non-strings before lower-casing
  • ->kebab-case: guard for strings and use clojure.string/lower-case

Prevents TypeError: "toLowerCase" of null in cljs paths.

Description:

Related issue (if applicable): fixes #

Checklist:

  • The code change is tested and works locally.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if necessary
  • There is no commented out code in this PR.
  • My changes generate no new warnings (check the console)

… null)

- aloof-sort-by: handle nils and non-strings before lower-casing
- ->kebab-case: guard for strings and use clojure.string/lower-case

Prevents TypeError: "toLowerCase" of null in cljs paths.
@codeGlaze
Copy link

This is an interesting patch I hadn't considered - I'm curious about how it cropped up for you. What happened that you caught this?

@Tales-K
Copy link
Author

Tales-K commented Nov 4, 2025

This bug occurs with some orcbrew files, I suspect they have something missing but I cannot find what it is.
It happens when you click on "Features" tab, either viewing or editing, for an Aarakocra character, using MegaPak - WotC Books.orcbrew file.

image

Before applying the fix, the site crashes and the screen turns black,. After the fix, everything works as expected.

Would you like me to add a warn log to the method or something like that?

@codeGlaze
Copy link

I was mostly curious how you found it so I can try to recreate it! :D

I'm always happy to have better error handling :)

Copy link

@codeGlaze codeGlaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice catch!

@codeGlaze codeGlaze merged commit 48de57e into Orcpub:develop Nov 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants