Skip to content

chore(deps)(deps-dev): bump recharts from 2.15.4 to 3.9.2 #1635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dependabot wants to merge 1 commit into from
Closed

chore(deps)(deps-dev): bump recharts from 2.15.4 to 3.9.2 #1635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/node-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"react": "^19",
"react-dom": "^19",
"react-router-dom": "^7",
"recharts": "^2",
"recharts": "^3",

@otReviewAgent otReviewAgent Jul 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Issue: Recharts v3 upgrade is not covered by chart-rendering verification

What's wrong
This PR changes the charting library across a major version, but the existing tests do not exercise the user-facing Recharts output. Because the only chart usage is in the Observability/Operations UI, the suite can stay green even if the upgraded library stops drawing the charts, changes legend behavior, or mishandles the multi-axis hardware chart.

Example
A regression where the Hardware Network & RPC chart renders no SVG or loses one of its two Y-axis series after the v3 upgrade would still pass: the current spec clicks Hardware and only checks that /CPU|Memory|Disk/ text is visible.

Suggested direction
Add a deterministic Playwright or DOM test that feeds chartable data into the Operations view and asserts the Recharts-rendered surfaces, including at least one legend-interactive chart and the dual-Y-axis hardware chart. A build-only check is useful, but it will not catch the visual/runtime rendering regressions this migration can introduce.

For Agents
Add focused node-ui verification around Operations.tsx chart surfaces. Mock /api responses or use a deterministic fixture with enough operation and hardware history buckets, then prove the Observability charts render actual Recharts SVG paths/series, expected legend labels, and the multi-axis Hardware Network & RPC chart still shows both Peers and RPC (ms) series under Recharts v3.

"three": "^0.184.0",
"typescript": "^5.7",
"vite": "^6",
Expand Down
Loading
Loading