chore(deps)(deps-dev): bump recharts from 2.15.4 to 3.10.1#1978
chore(deps)(deps-dev): bump recharts from 2.15.4 to 3.10.1#1978dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [recharts](https://github.com/recharts/recharts) from 2.15.4 to 3.10.1. - [Release notes](https://github.com/recharts/recharts/releases) - [Changelog](https://github.com/recharts/recharts/blob/main/CHANGELOG.md) - [Commits](recharts/recharts@v2.15.4...v3.10.1) --- updated-dependencies: - dependency-name: recharts dependency-version: 3.10.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
| "react-dom": "^19", | ||
| "react-router-dom": "^7", | ||
| "recharts": "^2", | ||
| "recharts": "^3", |
There was a problem hiding this comment.
🟡 Issue: Recharts 3 needs explicit grid axis IDs for the multi-axis chart
What's wrong
The dependency bump changes Recharts' CartesianGrid/axis contract, but the existing Operations chart has custom Y axis IDs and leaves the grid on the default axis ID. That makes the monitoring chart lose grid lines after the upgrade, reducing the accuracy/readability of the operational telemetry view.
Example
Open the Operations hardware Network & RPC chart after installing Recharts 3. The chart still defines only left and right Y axes, while CartesianGrid defaults to Y axis 0; under Recharts 3 the grid no longer matches any Y axis, so the horizontal grid lines can disappear. Expected behavior is that the chart keeps its grid against the primary left axis.
Suggested direction
Audit the Recharts 3 migration notes against the existing chart JSX and add explicit yAxisId/xAxisId where charts use non-default axes. The visible fix here is to bind the Network & RPC CartesianGrid to the primary Y axis.
For Agents
In packages/node-ui/src/ui/pages/Operations.tsx, update the multi-axis Network & RPC chart's CartesianGrid to bind to the intended axis, likely yAxisId="left", while preserving the two series on left and right. Add a focused render assertion or screenshot/e2e check proving the grid still renders for the multi-axis chart after the Recharts 3 upgrade.
Recharts major upgrade is not backed by chart rendering validation
What's wrong
This PR changes a user-facing charting dependency across a major version, but the diff adds no regression test or validation evidence for the charts that consume it. Existing tests can pass while the actual Recharts surfaces are blank or chart-specific props stop behaving.
Example
A regression where Recharts v3 renders an empty ResponsiveContainer or breaks Legend/Tooltip interaction would still pass the current operations e2e checks, because they only assert labels like Hardware, CPU, Memory, Disk, or Error Hotspots are visible.
Suggested direction
Add or update an e2e/component test that exercises the Recharts surfaces using the upgraded package, and include a passing TypeScript/build check for the node UI.
Confidence note
I could not run the requested pnpm tsc command in this sandbox because pnpm is not installed; linked CI or a passing local run could close part of this gap.
For Agents
Look at packages/node-ui/src/ui/pages/Operations.tsx and packages/node-ui/e2e/specs/operations.spec.ts. Add coverage for the Recharts-backed Observability charts after the v3 bump, ideally asserting at least one chart surface/series renders in All Operations and Hardware with representative data, and keep a tsc/build validation in CI or PR evidence.
1 participant
Bumps recharts from 2.15.4 to 3.10.1.
Release notes
Sourced from recharts's releases.
... (truncated)
Commits
ffb91873.10.1411b6f2fix(bar): keep barGap correct when maxBarSize clamps the bar width (#2774) (#...58c321bchore(deps-dev): bump postcss from 8.5.10 to 8.5.22 (#7581)f08972bchore(deps-dev): bump the storybook group with 8 updates (#7578)89599d0chore(deps-dev): bump chromatic from 11.29.0 to 18.1.0 (#7579)3da7d87chore(deps-dev): bump typescript-eslint from 8.64.0 to 8.65.0 in the typescri...9764273chore(deps-dev): bump marked from 18.0.5 to 18.0.7 (#7577)a5d7737fix(tooltip): fall back to index-based search when label-based search returns...497e8dfchore(deps-dev): bump fast-uri from 3.1.2 to 3.1.4 (#7576)0776eb0chore(deps): bump immer from 11.1.9 to 11.1.15 (#7575)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for recharts since your current version.
Install script changes
This version adds
preparescript that runs during installation. Review the package contents before updating.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)