feat(docker): improve Dockerfile building with non-root user and replacing CMD with ENTRYPOINT#222
Conversation
|
New commit 3aa23e1 uses deterministic UID/GID (which is 1000:1000) in this case to run deeplx binrary. |
|
A small concern about the user creation on Alpine specifically: addgroup -g 1000 -S deeplx && adduser -h /app -G deeplx -SH -u 1000 deeplxMixing
Two cleaner options depending on which behavior you actually want:
Minor nit unrelated to Alpine: Otherwise the change looks good and the |
Drop explicit -u 1000/-g 1000 and let busybox assign from Alpine's system UID range (100-999), aligning with -S (system account) semantics. Reference the account by name in USER and --chown to avoid hard-coding a numeric UID that could collide with future Alpine releases or layered packages.
|
Thanks for the contribution and for the patience on the follow-up! On the release timing: we cut new versions only when a functionally-necessary change is ready to ship — Dockerfile improvements alone won't trigger a release on their own, so I can't give you a concrete date. If you'd like to start using the non-root image right away, the most straightforward path is to |
Resolves #221.
I also changed the followings for the Dockerfile:
docker run.If this PR is accepted, may I know when this change will be published?