chore: support modern exports - #7
Open
darcyrush wants to merge 1 commit into
Open
Conversation
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #6 and supersedes #2 and #3
The current exports are arguably incorrect as hinted at in #3. You can check this yourself here;
https://arethetypeswrong.github.io/?p=jsonpath-rfc9535%401.3.0
Node 20 is EoL and Node 22+ supports "requiring ESM". TypeScript 7 will not support the already questionable
"moduleResolution": "node"setting.This PR simplifies the project to being only ESM again and reduces the bundle size by ~75% by removing
srcfrom the bundle and the CJS / ESM build step. This in turn eliminates the "dual packaging" hazard entirely.@P0lip I'm not sure if you want to mark this as a major semver change? I am happy to update the version and the commit message if you disagree.
I will close the other PRs