Conversation
pcl-ce-automation
bot
added
🛠️ 等待审查
ruattd
requested changes
Mar 10, 2026
Contributor
ruattd
left a comment
ruattd
left a comment
There was a problem hiding this comment.
- 用基于 RPC 的 LifecycleCommandHandler 而不是自己处理参数，申请管理员的特性把 PromoteService 改造一下复用已存在的权限，另外注意改权限不要影响其他线程
- 不要在 Essentials 里面新建文件夹了，以及这种非核心服务不适合丢这里（考虑在 App 里面加一个 Tools？
- 这点东西怎么能造出来 3 个文件的
- 有一吨无意义的更改，你是不是应该考虑丢掉 VS 这个垃圾
Contributor
Author
|
3: 一个类型一个文件 qwq |
Contributor
Author
|
LifeCycleCommandHandler 会通过 RPC 把调用传回原程序（没权限），这对吗😰 |
pcl-ce-automation
bot
added
🚧 正在处理
Contributor
|
这对的，应该在原程序里面走线程提权并复用，而不是每次都现场跟用户申请权限 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.