Implement new .NET8 specific attributes to entry-format validation #516

marierin · 2025-01-15T13:45:06Z

No description provided.

Bumps [Moq](https://github.com/moq/moq) from 4.20.69 to 4.20.70. - [Release notes](https://github.com/moq/moq/releases) - [Changelog](https://github.com/devlooped/moq/blob/main/CHANGELOG.md) - [Commits](moq/moq.spikes@v4.20.69...v4.20.70) --- updated-dependencies: - dependency-name: Moq dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

…oq-4.20.70 Bump Moq from 4.20.69 to 4.20.70

Bumps `efCoreVersion` from 8.0.0 to 8.0.4. Updates `Microsoft.EntityFrameworkCore` from 8.0.0 to 8.0.4 - [Release notes](https://github.com/npgsql/efcore.pg/releases) - [Commits](npgsql/efcore.pg@v8.0.0...v8.0.4) Updates `Microsoft.EntityFrameworkCore.Design` from 8.0.0 to 8.0.4 - [Release notes](https://github.com/npgsql/efcore.pg/releases) - [Commits](npgsql/efcore.pg@v8.0.0...v8.0.4) Updates `Microsoft.EntityFrameworkCore.Relational` from 8.0.0 to 8.0.4 - [Release notes](https://github.com/dotnet/efcore/releases) - [Commits](dotnet/efcore@v8.0.0...v8.0.4) Updates `Microsoft.EntityFrameworkCore.InMemory` from 8.0.0 to 8.0.4 - [Release notes](https://github.com/npgsql/efcore.pg/releases) - [Commits](npgsql/efcore.pg@v8.0.0...v8.0.4) Updates `Microsoft.EntityFrameworkCore.Proxies` from 8.0.0 to 8.0.4 - [Release notes](https://github.com/npgsql/efcore.pg/releases) - [Commits](npgsql/efcore.pg@v8.0.0...v8.0.4) Updates `Microsoft.EntityFrameworkCore.Sqlite` from 8.0.0 to 8.0.4 - [Release notes](https://github.com/npgsql/efcore.pg/releases) - [Commits](npgsql/efcore.pg@v8.0.0...v8.0.4) Updates `Npgsql.EntityFrameworkCore.PostgreSQL` from 8.0.0 to 8.0.4 - [Release notes](https://github.com/npgsql/efcore.pg/releases) - [Commits](npgsql/efcore.pg@v8.0.0...v8.0.4) --- updated-dependencies: - dependency-name: Microsoft.EntityFrameworkCore dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Microsoft.EntityFrameworkCore.Design dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Microsoft.EntityFrameworkCore.Relational dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Microsoft.EntityFrameworkCore.InMemory dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Microsoft.EntityFrameworkCore.Proxies dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Microsoft.EntityFrameworkCore.Sqlite dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Npgsql.EntityFrameworkCore.PostgreSQL dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.8.0 to 17.10.0. - [Release notes](https://github.com/microsoft/vstest/releases) - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md) - [Commits](microsoft/vstest@v17.8.0...v17.10.0) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

…icrosoft.NET.Test.Sdk-17.10.0 Bump Microsoft.NET.Test.Sdk from 17.8.0 to 17.10.0

…fCoreVersion-8.0.4 Bump efCoreVersion from 8.0.0 to 8.0.4

1nf0rmagician

Two additional remarks

Please update the documentation. Fell free to not only add your new additions but also correct any issues you encountered when using the documentation to understand the Entry concept. As I told you at the beginning, it would be nice if the next person getting into it could understand what it is and what it can be used for without to much additional help from us personally.
Did you decide against the new Base64String validation attribute for a specific reason? Coincidently, we could probably make good use of that validation attribute with the new File System we want to provide😬

src/Moryx.CommandCenter.Web/src/modules/models/EntryValidation.ts

src/Moryx/Serialization/DefaultSerialization.cs

src/Moryx.CommandCenter.Web/src/modules/models/EntryValidation.ts

1nf0rmagician · 2025-01-22T05:52:09Z

One more comment to add: Please check this site, it explains the two different attributes to validate collection length and string length. I think it would be alright to share the field in the validation class, as we also have the IsCollection flag on the entry. Bt you need to make sure in the serialization (and on the consuming site as well) to ignore the wrong attributes and to check for the right things when validating 😊

docs/articles/Core/Serialization/EntryFormat.md

src/Moryx/Configuration/PossibleValuesSerialization.cs

1nf0rmagician

I'm sorry but I don't get the optimization you did in the code since the last review, could we please have a quick chat about it 🙈

1nf0rmagician · 2025-03-20T11:52:58Z

src/Moryx/Serialization/DefaultSerialization.cs

-                }
-                else if (attribute is RegularExpressionAttribute regexAttribute)
-                    validation.Regex = regexAttribute.Pattern;
-                else if (attribute is StringLengthAttribute strLength)


Am I missing something or are the RegularExpressionAttribute and the StringLengthAttribute missing? 🤔

1nf0rmagician · 2025-03-20T11:58:45Z

src/Moryx/Serialization/DefaultSerialization.cs

+#if NET8_0
+            var validationAttribute = attributeProvider.GetCustomAttribute<AllowedValuesAttribute>();
+            var allowedValues = validationAttribute?.Values.Select(o => o.ToString()) ?? Enumerable.Empty<string>();
+            if (allowedValues.All(value => !string.IsNullOrEmpty(value))) 


What is the intention behind this if? From my understanding this would cause the allowed values to be used only if the empty string is not part of the AllowedValues, is that intended?
Also this method will throw a NullRef exception, if someone in a .net 8 application uses the possible values attribute for a list of primitive types or an enum.
Also the PossibleValues attribute is ignored, if the AllowedValues attribute is used (This is the only thing i'm fine with, if you intended it)

This is what i would expect, but please check if i missunderstood something 🙈

if( allowedValues is null) { return allowedValues?.Distinct().ToArray(); }

1nf0rmagician · 2025-03-20T17:23:07Z

Also please check the unit test, they should be resolved by the changes necessary. But you might want to check them if not

dbeuchler · 2025-04-08T08:22:29Z

Directory.Build.targets

-    <PackageReference Update="Microsoft.NET.Test.Sdk" Version="17.8.0" />
-    <PackageReference Update="Moq" Version="4.20.69" />
+    <PackageReference Update="Microsoft.NET.Test.Sdk" Version="17.*" />
+    <PackageReference Update="Moq" Version="4.*" />


I would not use a generic version here. Make it explict.

dbeuchler · 2025-04-08T08:23:11Z

Directory.Build.targets

@@ -18,8 +18,8 @@
  <!-- Package versions for package references across all projects -->
  <ItemGroup>
    <!--3rd party dependencies-->
-    <PackageReference Update="Microsoft.NET.Test.Sdk" Version="17.8.0" />
-    <PackageReference Update="Moq" Version="4.20.69" />
+    <PackageReference Update="Microsoft.NET.Test.Sdk" Version="17.*" />


Same here - i would use an explict version here. In the past there were a lot of changes between the SDKs, also in minors.

dbeuchler · 2025-04-08T08:23:40Z

docs/articles/Core/Serialization/EntryFormat.md

@@ -54,33 +54,109 @@ The recursive `SubEntries` structure represents properties of a `EntryValueType.
 Example class:

 ````cs
-public class Root
+public class PackagingResource


Root sounds better than this

dbeuchler · 2025-04-08T08:24:16Z

docs/articles/Core/Serialization/EntryFormat.md

-    [DisplayName("Bob")]
-    public Foo Blah { get; set; }
+    [EntrySerialize]
+    [isRequiered]


Isnt it RequiredAttribute?

dbeuchler · 2025-04-08T08:24:27Z

docs/articles/Core/Serialization/EntryFormat.md

-    public Foo Blah { get; set; }
+    [EntrySerialize]
+    [isRequiered]
+    public Product Product_1 { get; set; }


No underscores in property-names

dbeuchler · 2025-04-08T08:25:42Z

src/Moryx.CommandCenter.Web/src/modules/models/EntryValidation.ts

+    public regex: string;
+    public isRequired: boolean;
+    public isPassword: boolean;
+    public deniedValue: string[];


Do you know why this is not plural here? deniedValues

1nf0rmagician and others added 8 commits November 23, 2023 06:21

Bump version to 10.0.0

98622d8

Merge pull request #360 from PHOENIXCONTACT/dependabot/nuget/future/M…

fada832

…oq-4.20.70 Bump Moq from 4.20.69 to 4.20.70

Merge pull request #431 from PHOENIXCONTACT/dependabot/nuget/future/M…

9a1e61d

…icrosoft.NET.Test.Sdk-17.10.0 Bump Microsoft.NET.Test.Sdk from 17.8.0 to 17.10.0

Merge pull request #425 from PHOENIXCONTACT/dependabot/nuget/future/e…

a675a5a

…fCoreVersion-8.0.4 Bump efCoreVersion from 8.0.0 to 8.0.4

Merge remote-tracking branch 'origin/dev' into future

5a9be62

marierin requested a review from 1nf0rmagician January 15, 2025 13:45

1nf0rmagician reviewed Jan 22, 2025

View reviewed changes

src/Moryx.CommandCenter.Web/src/modules/models/EntryValidation.ts Outdated Show resolved Hide resolved

src/Moryx/Serialization/DefaultSerialization.cs Outdated Show resolved Hide resolved

src/Moryx.CommandCenter.Web/src/modules/models/EntryValidation.ts Show resolved Hide resolved

marierin force-pushed the entry-project branch from 88a972c to 4d191aa Compare February 10, 2025 11:24

1nf0rmagician reviewed Feb 11, 2025

View reviewed changes

Merge remote-tracking branch 'origin/dev' into future

3a19f4c

1nf0rmagician requested changes Feb 18, 2025

View reviewed changes

src/Moryx/Configuration/PossibleValuesSerialization.cs Outdated Show resolved Hide resolved

src/Moryx/Configuration/PossibleValuesSerialization.cs Outdated Show resolved Hide resolved

src/Moryx/Configuration/PossibleValuesSerialization.cs Outdated Show resolved Hide resolved

1nf0rmagician reviewed Feb 24, 2025

View reviewed changes

1nf0rmagician and others added 2 commits March 3, 2025 12:37

Merge remote-tracking branch 'origin/dev' into future

3154cc6

Merge remote-tracking branch 'origin/dev' into future

cb1bc96

1nf0rmagician requested changes Mar 20, 2025

View reviewed changes

marierin added 8 commits March 21, 2025 11:11

Implement new .NET8 specific attributes to the entry-format validaton

245a0bf

Add new example to EntryFormat-documentation

e0883d1

Connect possibleValuesAttribute with allowedValuesAttribute

6a9b52b

Correct errors in the example

2818113

Revise the PossibleValues function

9d3852f

Move allowedValues check to base class

00c588d

Reverte line-ending

d644bc8

Add missing attributes

18b3077

marierin force-pushed the entry-project branch from 09719b5 to 18b3077 Compare April 2, 2025 08:49

dbeuchler reviewed Apr 8, 2025

View reviewed changes

Implement new .NET8 specific attributes to entry-format validation #516

Are you sure you want to change the base?

Implement new .NET8 specific attributes to entry-format validation #516

Uh oh!

Conversation

marierin commented Jan 15, 2025

Uh oh!

1nf0rmagician left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

1nf0rmagician commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

1nf0rmagician left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

1nf0rmagician commented Mar 20, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

1nf0rmagician commented Jan 22, 2025 •

edited

Loading