Skip to content

Allow adding MemoryImage using URL #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 13, 2014
Merged

Conversation

ivanlanin
Copy link
Contributor

The current version of PHPWord only allow dynamic image when the source string contains .php. When allow_url_open = on, the GD library functions that we use, e.g. imagecreatefromgif, can get images from URL.
Code sample:

$source = 'http://php.net/images/logos/php-med-trans-light.gif';
$section->addText("Remote image from: {$source}");
$section->addMemoryImage($source);

I've also done the following things:

  1. Create 2 more samples from the old folder
  2. Create unit test for PHPWord\Settings Add XMLWriter Compatibility option #119
  3. Test & migrate the remaining old samples as per Mission to 0.7.1 #43

@Progi1984
Copy link
Member

@ivanlanin Do I merge it ?

@Progi1984 Progi1984 added this to the 0.7.1 milestone Mar 13, 2014
@Progi1984 Progi1984 mentioned this pull request Mar 13, 2014
5 tasks
@ivanlanin
Copy link
Contributor Author

Ok. Please merge. I've just finished testing footnotes. It turns out that MS Word cannot open the DOCX with footnotes that we created. OpenOffice doesn't have any problem. I fixed the bug.

Progi1984 added a commit that referenced this pull request Mar 13, 2014
Allow adding MemoryImage using URL
@Progi1984 Progi1984 merged commit 645d237 into PHPOffice:develop Mar 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants