Clone row issue [Text between two tables (both with merge cell) got c… #1981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lone when applying cloneRow to last merge row of first table] fix
Progi1984
force-pushed
the
master
branch
3 times, most recently
from
2d9f999 to
e458249
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clone row issue [Text between two tables (both with merge cell) got clone when applying cloneRow to the last row (with merge cell) of first table] fix
Description
I have two tables in a word template, both with merge cells. When applying cloneRow to the last row (with merge cells) on the first table, the text between the first and second table got clone as well.
Fixes # (issue)
In the merge cell checking, added a checking to stop cloning when close table tag is found.
if (preg_match('#</w:tbl>#', $tmpXmlRow)|| (!preg_match('#<w:vMerge/>#', $tmpXmlRow) && !preg_match('#<w:vMerge w:val="continue"\s*/>#', $tmpXmlRow))) { break; }Checklist:
composer run-script check --timeout=0and no errors were reported