Skip to content

Create basic CircleCI config #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Create basic CircleCI config #47

wants to merge 8 commits into from

Conversation

ravanscafi
Copy link
Member

@ravanscafi ravanscafi commented Jun 13, 2019

Esse PR configura o Circle CI para rodar no repositório. Com isso podemos atacar a issue #43.
Tomei a liberdade de trocar o npm pelo yarn por todos os benefícios que o yarn traz.
Além disso simplifiquei um pouco os scripts de build.

Atualmente, o único "teste" que o CI está fazendo é rodar:

yarn production

A ideia agora é criar uma suite de testes e substituir esse comando 😉

PS: os deploys do netlify pra dev.phpsp estão falhando. É assim mesmo?
Vamos dropar esse ambiente de staging? (se for o caso, já tiro o staging dos build scripts)
Na minha opinião os deploy previews que o netlify geram já são o suficiente pra testar.

@ravanscafi ravanscafi added the enhancement New feature or request label Jun 13, 2019
@ravanscafi ravanscafi self-assigned this Jun 13, 2019
@ravanscafi ravanscafi marked this pull request as ready for review June 13, 2019 18:31
@ravanscafi
Copy link
Member Author

Vou abrir outro PR pra ver se resolve o problema do netlify (alteramos algumas configs)

@ravanscafi ravanscafi closed this Jun 14, 2019
@ravanscafi ravanscafi deleted the setup-ci branch June 14, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant