Backport bitcoin#14897 and bitcoin#15834 and modify it to work with PIVX messages #2963
+404
−170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acks Co-authored-by: Suhas Daftuar <[email protected]>
If a transaction is already in-flight when a peer announces a new tx to us, we schedule a time in the future to reconsider whether to download. At that future time, there was a bug that would prevent transactions from being rescheduled for potential download again (ie if the transaction was still in-flight at the time of reconsideration, such as from some other peer). Fix this.
Duddino
force-pushed
the
tx_request_backport
branch
from
74dfda3 to
405a7b5
Compare
Cherry-pick of ef14b19 dashpay#3397
…tRequest is called Cherry-pick of 26fcd3f dashpay#3397
Duddino
force-pushed
the
tx_request_backport
branch
from
405a7b5 to
8d68f12
Compare
Duddino
force-pushed
the
tx_request_backport
branch
from
33f6090 to
9d29659
Compare
Duddino
force-pushed
the
tx_request_backport
branch
from
8b334ca to
488d34c
Compare
Duddino
force-pushed
the
tx_request_backport
branch
from
f52d7c5 to
2ca6dd2
Compare
Liquid369
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of dashpay#3397
This PR introduces ObjectRequests, and removes the dash-specific workarounds
AskForandRemoveAskForHow does it work (Taken from bitcoin#14897)
This PR introduces bias toward outbound connections (they have higher priority when a node chooses from whom it should request a transaction) and randomizes the order.
GETDATA requests queue is created after processing all incoming messages from all nodes.
After this fix, if the incoming messages were [I1, I2, I3, O1, O2, O3, O4], the queue for GETDATA may look like [O2, O1, O3, O4, I1, I3, I2, ….].
If {I1, I2, I3} were significantly earlier (but the difference is less than TX_TIMEOUT=60 s) than others, the queue for GETDATA may look like [I2, O2, O1, O3, O4, I1, I3, ….].