Skip to content

Conversation

@mkaguer
Copy link
Contributor

@mkaguer mkaguer commented Dec 22, 2023

Currently there is only one scipy integrator classes that uses RK45. I created a general integrator class that uses RK45 by default called ScipyIntegrator, this is the parent class. Then, I created child classes that inherit from this class but pass different solvers. I added two more solvers currently not available, BDF and LSODA. These solvers work for stiff problems.

@codecov
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.3%. Comparing base (dfc0387) to head (953c38d).
⚠️ Report is 13 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2880   +/-   ##
=====================================
  Coverage   90.3%   90.3%           
=====================================
  Files        148     148           
  Lines       8623    8633   +10     
=====================================
+ Hits        7789    7799   +10     
  Misses       834     834           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ma-sadeghi ma-sadeghi self-requested a review December 24, 2023 21:35
Copy link
Member

@ma-sadeghi ma-sadeghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, can you add some unit tests?

@mkaguer
Copy link
Contributor Author

mkaguer commented Jan 7, 2024

Nice, can you add some unit tests?

Yea, I'll do that this week when I get back to work!

@mleot
Copy link

mleot commented Feb 7, 2024

I also have motivation to add more integrators to OpenPNM. I can help out with writing some of these unit tests.

@jgostick
Copy link
Member

jgostick commented Aug 7, 2024

Hey @mkaguer, are we still interested in merging this PR? I have refreshed it by merge the latest dev into it. It now passes the non-mac tests. Should we merge it? Any change you could address @ma-sadeghi's request to add a test or two?

@TKlokgieters
Copy link
Contributor

TKlokgieters commented Oct 14, 2025

@jgostick Any chance this can be merged? As far as I can tell the unit tests were committed in/with [a6cc209] .
I'd also be interested in solving stiff problems using the different integrator methods.

If anything is missing I'd be happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants