-
Notifications
You must be signed in to change notification settings - Fork 183
Added more Scipy integrators to handle stiff problems #2880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2880 +/- ##
=====================================
Coverage 90.3% 90.3%
=====================================
Files 148 148
Lines 8623 8633 +10
=====================================
+ Hits 7789 7799 +10
Misses 834 834 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, can you add some unit tests?
Yea, I'll do that this week when I get back to work! |
|
I also have motivation to add more integrators to OpenPNM. I can help out with writing some of these unit tests. |
|
Hey @mkaguer, are we still interested in merging this PR? I have refreshed it by merge the latest |
Currently there is only one scipy integrator classes that uses RK45. I created a general integrator class that uses RK45 by default called ScipyIntegrator, this is the parent class. Then, I created child classes that inherit from this class but pass different solvers. I added two more solvers currently not available, BDF and LSODA. These solvers work for stiff problems.