-
Notifications
You must be signed in to change notification settings - Fork 184
Merging dev onto release #3028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jgostick
wants to merge
17
commits into
release
Choose a base branch
from
dev
base: release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Merging dev onto release #3028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge release branch back into dev
- Removed circular import from pyproject #bug
- Moved to the "src/openpnm" file structure #maint - Added bump-to-version package in the related actions #maint - Removed the setup.cfg file since all version bump info is now in pyproject.toml #maint
but I did change quite a few things # Conflicts: # .github/workflows/bump-version-dev.yml
Optimize `_find_trapped_pores()` in invasion percolation trapping (~20× faster) #enh
# Conflicts: # .github/workflows/bump-version-dev.yml
This is actually just adding a few commits that I forgot to push before merging the last one. Apparently my playing around in a playground repo to figure out the bump-to-version stuff made me a bit careless!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release #3028 +/- ##
=========================================
- Coverage 90.3% 88.2% -2.1%
=========================================
Files 148 152 +4
Lines 8629 8909 +280
=========================================
+ Hits 7795 7866 +71
- Misses 834 1043 +209 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.