Linking to raw partition table txt to prevent save link issue#116
Merged
m-weigand merged 1 commit intoPNDeb:trixiefrom Apr 5, 2025
Merged
Linking to raw partition table txt to prevent save link issue#116m-weigand merged 1 commit intoPNDeb:trixiefrom
m-weigand merged 1 commit intoPNDeb:trixiefrom
Conversation
Collaborator
|
thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The partition table file link goes to the Github page (html) and not the raw (txt) file so if a person unfamiliar with Github is following instructions right clicks and saves the link they'll save the html and the rkdeveloptool won't be able to parse it causing an unintuitive error. This patch proposes linking directly to the raw file to prevent this issue.
Maintenance burden: when these instructions are merged into main, the link would be need to be updated. I understand if that's a deal breaker and I'd be happy to amend this PR for more verbose instructions instead.