Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse baroclinic_instability_model in sharding script and add test #116

Merged
merged 45 commits into from
Mar 30, 2025
Merged

Reuse baroclinic_instability_model in sharding script and add test #116

merged 45 commits into from
Mar 30, 2025

Conversation

glwagner
Copy link
Collaborator

@glwagner glwagner commented Mar 28, 2025 •
edited
Loading

Generalizes CompileAndRun.yml.

@glwagner glwagner changed the title Reuse model in sharding script and add test Reuse baroclinic_instability_model in sharding script and add test Mar 28, 2025
@simone-silvestri simone-silvestri mentioned this pull request Mar 28, 2025
Merged
giordano
giordano reviewed Mar 29, 2025
View reviewed changes
.github/workflows/Run.yml
@@ -68,9 +61,30 @@ jobs:
uses: ./.github/workflows/CompileOrRun.yml
with:
sim_type: ${{ matrix.sim_type }}
grid_type: ${{ matrix.sim_type == 'baroclinic_instability' && 'simple_lat_lon' || 'gaussian_islands' }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/PRONTOLab/GB-25/actions/runs/14148328037?pr=116

The workflow is not valid. .github/workflows/Run.yml (Line: 64, Col: 18): Invalid input, grid_type is not defined in the referenced workflow.

🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, its grid_name

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually I will just change them all to grid_type, its better

@giordano
Copy link
Collaborator 

low memory! at or below SIGTERM limits: mem  4.00%, swap 100.00%
sending SIGTERM to process 4606 uid 1001 "julia": badness 1792, VmRSS 14831 MiB

[4606] signal 15: Terminated
in expression starting at /home/runner/work/GB-25/GB-25/sharding/sharded_baroclinic_instability_simulation_run.jl:62

chart_stacked_area_time_a332c9d0-e2fd-4eca-96d4-d81987e956ed

@glwagner
Copy link
Collaborator Author

dammit

foiled again

@glwagner
Copy link
Collaborator Author

@giordano shall we merge this?

@giordano
Copy link
Collaborator

Yes, I'm ok with that, although we're always very close to fill up the memory on CI: https://github.com/PRONTOLab/GB-25/actions/runs/14153264969?pr=116#summary-39649233194. Can we slightly reduce the size of the problem?

@glwagner
Copy link
Collaborator Author

Ah, thanks for noticing that, there was actually a mistake in the default (resolution of "2 degrees" implies "resolution fraction" of 1/2). I change the default to resolution of 4 degrees. I also changed the way we compute grid points from resolution to be more friendly to division by powers of 2 (now we use factors of (3 * 2^n) from which we do have a roughly equivalent resolutions in degrees --- the difference between 360 and 384).

@glwagner glwagner merged commit a4f18ae into main Mar 30, 2025
13 checks passed
@glwagner glwagner deleted the glw/groomed-sharding branch March 30, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glwagner @giordano @simone-silvestri