Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Feature] 支持 stream agent 流式返回step和message #345
[New Feature] 支持 stream agent 流式返回step和message #345
Changes from 5 commits
d3cfef2
3fb74a1
cc8b31c
72f97f6
6ad4797
2d3c851
c95bde7
8c520b2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个是为什么呀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
特别不好意思,这个是对
mypy
的妥协:这里直接
pass
或者raise
都会mypy
编译器报错,原因应该是返回AsyncIterator
时,如果内部没有yield
就认为返回值是Coroutine
,从而导致和子类重载函数返回值类型(FunctionAgent._run_stream
)不同而报错;由于我一直没能找到通过mypy
检测的抽象方法@abc.abstractmethod async def _run_stream
的返回值数据类型,就很丑陋的if False:
了,哭哭There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
噢噢,好吧,那我觉得可以先保留这个(不过或许
if False
可以用if typing.TYPE_CHECKING
代替,顺带可以在注释里加个HACK
标记)~