Skip to content

[SOT] Always use dummy_guard when fallback error occurred #72194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

SigureMo
Copy link
Member

PR Category

Execute Infrastructure

PR Types

Bug fixes

Description

这里针对 disable_eval_frame = True 逻辑不确定原因,可能是过去有别的场景,但目前代码是没有 disable_eval_frame = True 的,一旦真的 disable_eval_frame = True 会在外部首次 translate guard 不为 None 的检查处挂掉,所以这里应该是可以安全删掉的

Copy link

paddle-bot bot commented Apr 11, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@SigureMo SigureMo changed the title [SOT] Always use dummy_guard when fallback error occurred [SOT] Always use dummy_guard when fallback error occurred Apr 11, 2025
@SigureMo SigureMo requested a review from Copilot April 11, 2025 06:55
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

python/paddle/jit/sot/opcode_translator/executor/executor_cache.py:295

  • The removal of the condition checking 'e.disable_eval_frame is False' in strict mode now causes a raise for every case where strict mode is enabled. Please double-check if this behavior is intended in all scenarios; if not, reintroducing a condition or adding a clarifying comment may be appropriate.
if is_strict_mode():

python/paddle/jit/sot/opcode_translator/executor/executor_cache.py:304

  • Since the conditional assignment of the guard function has been removed, 'dummy_guard' is always used. Consider verifying that components downstream do not rely on the previous behavior using simulator.guard_fn, and if needed, update the documentation or add a comment explaining this change.
dummy_guard,

@SigureMo SigureMo requested review from zrr1999 and gouzil April 11, 2025 15:18
@SigureMo SigureMo merged commit 85e1c9a into PaddlePaddle:develop Apr 11, 2025
34 checks passed
@SigureMo SigureMo deleted the sot/always-use-dummy-guard-when-fallback-error-occurred branch April 11, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants