Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Inference] Make inference_model on by default. #9879

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ZHUI
Copy link
Collaborator

@ZHUI ZHUI commented Feb 17, 2025

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

Others

PR changes

Others

Description

Make inference_model on by default.

Copy link

paddle-bot bot commented Feb 17, 2025

Thanks for your contribution!

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -1361,6 +1361,13 @@ def create_predictor(
paddle.set_device(predictor_args.device)
paddle.set_default_dtype(predictor_args.dtype)

if not is_paddlenlp_ops_available():
if predictor_args.inference_model:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是不是也应该判断一下model在白名单列表里?例如Llama/Qwen/Deepseek等等

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已更新 8fcf282

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.66%. Comparing base (235c24e) to head (b2630f2).
Report is 1 commits behind head on develop.

Current head b2630f2 differs from pull request most recent head 8fcf282

Please upload reports for the commit 8fcf282 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9879   +/-   ##
========================================
  Coverage    51.66%   51.66%           
========================================
  Files          739      739           
  Lines       117426   117426           
========================================
+ Hits         60668    60670    +2     
+ Misses       56758    56756    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants