Add configuration interface to expose certain config values

[NonSwag]

Previously, people (I) have been using the spigot and paper file configurations to determine whether the server is configured for proxy online mode
Now the spigot interface got deprecated for good reasons, but there is no alternative

This commit introduces methods to check the online mode and enablement status of Velocity and BungeeCord. These changes allow plugins to easily query proxy-related server configurations.

I would like to have some input on the method names since Bukkit uses getOnlineMode
Also, I wasn't really sure on whether to return bungee/velocity online mode true only if the server is actually using bungee or velocity

[Machine-Maker]

I wouldn't be immediately opposed to a new interface where select values from the configuration can be exposed more directly. I wouldn't want even more methods on Bukkit/Server for this though. I think there are probably these and several more values which we can consider stable enough to expose in the API.

[NonSwag]

I wouldn't be immediately opposed to a new interface where select values from the configuration can be exposed more directly. I wouldn't want even more methods on Bukkit/Server for this though. I think there are probably these and several more values which we can consider stable enough to expose in the API.

I like that idea, let me cook something up

[NonSwag]

I've added a new interface ServerConfiguration

[Warriorrrr]

Probably wanna note here that this class doesn't aim to expose every single config option in existance, only select ones.

[Andre601]

I feel like "selected critical settings." still makes it rather vague. Like why exactly are those critical? Are they critical for the server? The plugin dev? Both?

Maybe mentioning why they are considered critical would be beneficial here.

[electronicboy]

While I approve of the general concept of this, I'm not entirely fond about having highly specific stuff exposed if the context starts relating into stuff like security aspects, etc; i.e. what happens if we add a brand new forwarding mechanism that has its own option, does that get merged into the existing one or do we have an entire open hole? Do we really need this level of accessibility?

[Andre601]

Some comments regarding the comments.

[Andre601]

I feel like "selected critical settings." still makes it rather vague. Like why exactly are those critical? Are they critical for the server? The plugin dev? Both?

Maybe mentioning why they are considered critical would be beneficial here.

[NonSwag]

While I approve of the general concept of this, I'm not entirely fond about having highly specific stuff exposed if the context starts relating into stuff like security aspects, etc; i.e. what happens if we add a brand new forwarding mechanism that has its own option, does that get merged into the existing one or do we have an entire open hole? Do we really need this level of accessibility?

As written in the ServerConfiguration docs, it only aims to provide the most important settings
In my opinion there is nothing else that is really important to be exposed here as well at the moment
but I think this is better discussed internally

"This interface doesn't aim to cover every possible server configuration option but focuses on selected critical settings."

[electronicboy]

these settings are important why? What is the merit of exposing them individually rather than exposing the underlying concepts behind them?

[NonSwag]

I don't think I can follow. What do you mean by "the underlying concepts"?
The problem is that it isn't possible to check whether the server is configured for online mode and changing the Server#getOnlineMode impl seems iffy
So exposing them here/at all is kinda critical

[electronicboy]

Yes, so, isProxyOnline mode makes sense, individual bungee/velocity forwarding mode ones, I'm not sure about

[NonSwag]

You are right, thinking about it, I don't see a real upside in exposing them.
I think I am going to remove them

[NonSwag]

I removed the forwarding mode related methods
I would suggest for the distant future, moving stuff like getPort and getIp and other methods from the Bukkit interface to this class to unclutter that mess of a class

[Andre601]

Yes, so, isProxyOnline mode makes sense, individual bungee/velocity forwarding mode ones, I'm not sure about

It could be useful in case there would be Velocity-only features to use through Paper in the future.
Tho, that could also be checked via some message channel stuff I suppose.

[lynxplay]

If there are such features in the future, we can expand this type 😉

[electronicboy]

I mean, the two major things I'd imagine plugins might want to see on this front are "Are we in online mode?" and "Are we behind a proxy?" disambiguation is complex, I generally wouldn't want us to be in a state where we add support for some new proxy mode and now every plugin relying on this API to check that is broken