make bookshelf power configurable and refresh enchantment hint of menu after editing bookshelf power #12345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome to paper 🥳 It appears you commit / generate a whole slew of completely unrelated and invalid changes. |
|
I would suggest rebasing this PR or creating a new one |
I don't want to create a new one because this is my first PR and its number is 12345. I will look into rebasing the codes |
I-am-ddang
force-pushed
the
feat-enchantment-hint-with-configurable-bookshelf
branch
2 times, most recently
from
8248809 to
338303f
Compare
|
wait. it is not done. I will inform it is ready for review when I end all of rebase procedure |
I-am-ddang
force-pushed
the
feat-enchantment-hint-with-configurable-bookshelf
branch
2 times, most recently
from
64bc304 to
597f186
Compare
|
I did it. I am now the master of rebase. I am ready for review. |
|
@lynxplay @electronicboy |
I-am-ddang
force-pushed
the
feat-enchantment-hint-with-configurable-bookshelf
branch
from
597f186 to
894631f
Compare
github-project-automation
bot
moved this from Awaiting review
to Closed
in Paper PR Queue
|
wait I will reopen PR right now. it was accident |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.