fix(minimessage): preserve transformed component children when serializing gradients - #1442
Closed
flennium wants to merge 1 commit into
Closed
Conversation
flennium
marked this pull request as ready for review
August 8, 2026 19:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed PR
Title
fix(minimessage): preserve transformed component children when serializing gradients
Body
Fixes #1383
MiniMessage gradient and rainbow virtual components retain a serializer substitute for their canonical parsed form. After a component transformation such as
replaceText, the virtual component can have new children while the renderer still points at the old substitute, causing removed text to reappear during serialization.The serializer claim is now retained for the parsed virtual component, including nested canonical substitutes, and declined for later-transformed virtual instances so their current children are serialized. Adds regression coverage for the reported case and related gradient/style round trips.
Tested with
./gradlew :adventure-text-minimessage:checkand./gradlew check.