Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Disease Rework #28451

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

Migratingcocofruit
Copy link
Contributor

@Migratingcocofruit Migratingcocofruit commented Feb 19, 2025

What Does This PR Do

A detailed writeup of all changes can be found here
in short:

  • Advanced diseases now have a random cure generated.
  • Advanced diseases no longer present their details by default and need to be analyzed first.
  • Advanced diseases change their strain when mutating, which makes them unknown again.
  • Advanced diseases can mutate spontaneously while in a host
  • Some symptoms can now be treated using reagents. These symptoms stop acting so long as their treating reagents are in the blood stream, and they symptoms that can be treated are limited to those that couldn't be treated otherwise. The treating reagents are removed at an accelerated rate
  • Advanced diseases spawned by events gain bonus stats depending on the event's severity.
  • Disease outbreak can now be a major event
  • Admins can now create their own custom disease when doing an admin disease outbreak event, allowing for direct stat boosts as well as trait selection
  • The antibodies metabolism traits has been removed
  • Virology gets new chems to help them modify diseases without needing to reanalyze them and to prevent healing viruses from mutating

Why It's Good For The Game

Diseases are currently trivial to deal with, to the point where you don't need a virologist at all except in some very few edge cases where a disease has the correct symptom combination to allow it to be stealthy(which usually makes it very benign or makes it cure itself).
In addition, the majority of threats and challenges, specifically the severe ones, the station has to deal with throughout the shift are either combat based(blob, xenos, terrors, morph, demons, etc) or things mostly beyond the station's control, where fixing the damage caused is the only recourse(meteors, APC short, etc).
This PR aims to make diseases more than just a mild inconvenience that is cured by clicking someone with a health analyzer and sending a message on comms and more of a challenge in it's own right that the station in general, and the virologist specifically will have to face.

Images of changes

Testing

  • Analyzed diseases in the PANDEMIC
  • Deleted disease data from the database in the pandemic
  • treated symptoms
  • cured diseases
  • created disease outbreak events

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

image

🆑
add: Stabilizing agar - prevents disease from randomly mutating
add: Tracking agar - Makes new strains created from the tracked diseases to be analyzed instantly provided the first tracked strain is known
del: anti bodies metabolism symptom removed
tweak: Advanced diseases now need to be analyzed to display data
tweak: Advanced diseases now randomly generate cures
tweak: Advanced diseases can now spontaneously evolve inside a host
tweak: Disease outbreak can now a be a major events and gives the disease random bonus stats depending on severity
tweak: Some symptoms can now be treated using reagents(full list on the hackmd document), which removes those reagents at an accelerated rate.
/:cl:

Migratingcocofruit and others added 30 commits August 10, 2024 23:04
…ng the cure and adding/subtracting symptoms"

This reverts commit 124dd48.
…eak of a virus of their choosing. Allows virus creation when choosing virus to give someone or for an outbreak.
…om not acting purge some of the reagent that treated it
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally TGUI This PR modifies TGUI, will conflict labels Feb 19, 2025
@Pennwick
Copy link
Contributor

This seems like a lot to have to deal with. How will Virus's ability to evolve inside a host effect the curing process? I may be misreading the code but it seems like every time virus evolves into a new strain the cure changes as well. Wouldn't a virus rapidly start evolving faster than it could be cured after it mutates a few times? Or do vaccines work on all strains of the virus?

@Migratingcocofruit
Copy link
Contributor Author

This seems like a lot to have to deal with. How will Virus's ability to evolve inside a host effect the curing process? I may be misreading the code but it seems like every time virus evolves into a new strain the cure changes as well. Wouldn't a virus rapidly start evolving faster than it could be cured after it mutates a few times? Or do vaccines work on all strains of the virus?

Whenever the virus evolves it becomes a new strain. This means a new cure and a new vaccine. The current evolution probability should correspond to, on average, evolving every 20 minutes while 30 people are infected. Quarantine is going to be important. You can't just let people run around unprotected or you'll have to keep dealing with new viruses all the time, and people who feel ill should come to medbay rather than infect their entire department.

@ParadiseSS13-Bot ParadiseSS13-Bot added Testmerge Requested This PR has a pending testmerge request -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Feb 20, 2025
@Burzah Burzah added Feature This PR is a new addition to the game Balance This PR will modify how effective something is or isnt Tweak This PR tweaks something ingame labels Feb 20, 2025
@Pennwick
Copy link
Contributor

Getting spacemen to quarantine is nigh impossible but maybe it'll work out. One further concern in that Pentetic Acid isn't such a great cure reagent with its purging properties. Since its purging 4u of all the other chems every tick and the cure chance's range being between 10%-15% if its got any resistance.

@Migratingcocofruit
Copy link
Contributor Author

Getting spacemen to quarantine is nigh impossible but maybe it'll work out. One further concern in that Pentetic Acid isn't such a great cure reagent with its purging properties. Since its purging 4u of all the other chems every tick and the cure chance's range being between 10%-15% if its got any resistance.

Good point about pent. I'll get it replaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting approval This PR is waiting for approval internally Balance This PR will modify how effective something is or isnt Feature This PR is a new addition to the game Testmerge Requested This PR has a pending testmerge request TGUI This PR modifies TGUI, will conflict Tweak This PR tweaks something ingame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants