Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the *chirp emote from nymphs to Diona #28464

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ExusA
Copy link
Contributor

@ExusA ExusA commented Feb 20, 2025

What Does This PR Do

Adds the nymph emote *chirp to diona too.

Why It's Good For The Game

It's a tiny bit of RP content that lets diona show off their composite nature.
If they're made of things that can chirp, they ought to be able to chirp.

*chirp is a pretty short and quiet emote, so I don't expect people to find it irritating.

Testing

Used the emote, checked that the emote was in the *help menu, tested the keybind settings to make sure the emote showed up there and the keybind worked.
Listened to the emote at minimum and maximum age to make sure it still sounded alright.
chirp


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
soundadd: Diona can now chirp
/:cl:

@ExusA
Copy link
Contributor Author

ExusA commented Feb 20, 2025

I'm not sure if there's something that I need to do to make the new emote keybind go in the database, or if it's automatic. Let me know if that's something I need to figure out.

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Feb 20, 2025
Copy link
Contributor

@lewcc lewcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

@lewcc lewcc added the Feature This PR is a new addition to the game label Feb 21, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting approval This PR is waiting for approval internally labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Feature This PR is a new addition to the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants