Refactors SSTicker checks #28469
Open
Refactors SSTicker checks #28469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParadiseSS13-Bot
added
the
-Status: Awaiting type assignment
Contrabang
added
the
Refactor
ParadiseSS13-Bot
added
-Status: Awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
This PR cleans up SSTicker checks to use game stages, as opposed to checking if the ticker was running at all.
Fixes #18159
Why It's Good For The Game
Code consistency is good. Code being more specific is also good.
Testing
Complied, observed pre-start, spawned as drone, got in a skrell, opened a windoor, walked round, started round, committed suicide.
Declaration
Changelog
NPFC