Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendors can be righted much faster #28475

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ExusA
Copy link
Contributor

@ExusA ExusA commented Feb 21, 2025

What Does This PR Do

Makes vendors take 4 seconds to stand back up after falling, down from 14.

Why It's Good For The Game

14 seconds is a massively long time, to the point that people tend to leave vendors on the floor to avoid the hassle. It's disruptive to normal gameplay and the opportunity cost of avoiding an single strategy that has other safeguards isn't worth the trouble to the rest of the crew.

Even with a 4 second righting time, it can't reasonably be exploited for combat. For one, you can't vendorcrush somebody until they unflatten from the first crush, making combo-crushing the same person impossible, and 4 seconds is a long time to be standing still undisturbed in combat. If you have 4 seconds to spare to right a vendor in the situation that two people are fighting you, the second person gets 4 seconds of free hits on you while you wait.

Testing

Crushed myself with a vendor, righted the vendor and wrenched and unwrenched the vendor.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

vendorright

Changelog

🆑
tweak: Vendors are much faster to right.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Feb 21, 2025
@ExusA ExusA closed this Feb 21, 2025
@ExusA ExusA reopened this Feb 21, 2025
@ExusA
Copy link
Contributor Author

ExusA commented Feb 21, 2025

Sorry for closing, pressed the wrong button 😅

Copy link
Contributor

@PopeDaveThe3th PopeDaveThe3th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remember to lift with the knees

Copy link
Contributor

@lewcc lewcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for code

@lewcc lewcc added the Tweak This PR tweaks something ingame label Feb 21, 2025
@CinnamonSnowball
Copy link
Contributor

CinnamonSnowball commented Feb 21, 2025

Any particular reason to lower the 6s unwrenching time? This makes vendors a bit easier to steal for nothing other than consistency

@ExusA
Copy link
Contributor Author

ExusA commented Feb 21, 2025

Any particular reason to lower the 6s unwrenching time? This makes vendors a bit easier to steal for nothing other than consistency

You're probably right, it's not necessary. I've changed it back to 6.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting approval This PR is waiting for approval internally Tweak This PR tweaks something ingame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants