Implement new transport seam #221
Conversation
# Conflicts: # src/AcceptanceTests/NServiceBus.Transport.AzureServiceBus.AcceptanceTests.csproj # src/Tests/NServiceBus.Transport.AzureServiceBus.Tests.csproj # src/Transport/Administration/QueueCreator.cs # src/Transport/Administration/SubscriptionManager.cs # src/Transport/NServiceBus.Transport.AzureServiceBus.csproj # src/Transport/Sending/MessageDispatcher.cs # src/TransportTests/ConfigureAzureServiceBusTransportInfrastructure.cs # src/TransportTests/NServiceBus.Transport.AzureServiceBus.TransportTests.csproj
|
all tests are green now and it's targeting the latest version of core. @SeanFeldman do you have some chance to have a look at this, especially on the changes to the outgoing message customization that were necessary? |
|
@timbussmann, since the change to the native message customizations, is done, would it make sense to address #218 here as well? |
|
addressed the review comments |
| Guard.AgainstNull(nameof(SubscriptionNamingConvention), value); | ||
|
|
||
| // wrap the custom convention: | ||
| subscriptionNamingConvention = subscriptionName => |
There was a problem hiding this comment.
Should we do the wrapping when we actually use it? Otherwise we might (although I know it might a synthetic case) with funny behavior when people do
config.SubscriptionNamingConvention = config.SubscriptionNamingConvention
There was a problem hiding this comment.
that's a good point. In that case I'd rather vote to just remove the wrapper completely anyway though. Because once we call the convention, we don't really know anymore whether this is the default convention or a user-provided convention. So I'd say we leave it for now as is and if this is causing issues, we should look at just removing the wrapper.
Implements the new transport seam for ASB