-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update performance-tuning.md #7028
base: master
Are you sure you want to change the base?
Conversation
|
||
``` | ||
Degree of parallelism = Math.Ceiling(MaxConcurrency / NumberOfMessagesToFetch) | ||
``` | ||
|
||
The following examples illustrate how the formula is applied when the concurrency is greater or equal to 10. | ||
|
||
|`MaxConcurrency` | `DegreeOfReceiveParallelism` | `NumberOfMessagesToFetch` | | ||
|DegreeOfReceiveParallelism | MaxConcurrency | NumberOfMessagesToFetch | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI the order of these columns has been originally chosen like this because the thought process was that someone coming from NServiceBus might be most likely familiar with max concurrency (either the default value or the value they have explicitly set). We were assuming someone would then come from the angle of "I set the concurrency to LimitProcessingConcurrencyTo(100) and which row is that in the table..."
I would still argue the previous way makes more sense for most users. // cc @mauroservienti
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting! then can we flip the formula? As a reader, I expect the table to match the order of the formula
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if you use the following order?
|MaxConcurrency | NumberOfMessagesToFetch | DegreeOfReceiveParallelism |
then it reads naturally from left to right following the formula and the two first columns are the input formula and the right most is the result.
The ServicePointManager stuff would still be relevant for earlier versions of NServiceBus that can still run on .NET Framework, so it seems like it would be better to introduce partials that could keep that information around for those. It would be good to then point out that they are only relevant for .NET Framework, though. |
This PR deletes the references to ServicePointManager from the Performance tuning page of the AWS SQS transport.
I also updated the table to have the same order as the formula above.