Skip to content

Conversation

@mamadaliev
Copy link

@mamadaliev mamadaliev commented Aug 3, 2019

Hello, @Patreon!
Please merge my changes if you think these changes are correct.

1. Optimize imports in PatreonAPITest and PatreonOAuthTest classes.

// from:
import org.mockito.Matchers;
import org.powermock.api.mockito.PowerMockito;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;

// to:
import org.mockito.*;

2. Fix assertion to simplify in PatreonAPITest class.

// from:
assertEquals(false, campaign.isChargedImmediately());

// to:
assertFalse(campaign.isChargedImmediately());

3. Fix property access modifier to private.

// from:
PatreonOAuth oauth = ...

// to:
private PatreonOAuth oauth = ...

4. Remove "Exception" from "testAuthorizationURL" throws list.

// from:
public void testAuthorizationURL() throws Exception ...

// to:
public void testAuthorizationURL() ...

Please do not mark this as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant