Trigger change events for parent model keys #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visigoth
force-pushed
the
master
branch
2 times, most recently
from
3d587a9 to
58a6ca3
Compare
externally This makes sense because a collection changing externally is the equivalent of a parent set() operation for the collection's key. This enables scenarios like listening for changes on a parent object and persisting them without listening for changes to each of the parent object's relationed collections separately.
visigoth
force-pushed
the
master
branch
3 times, most recently
from
12971f4 to
ed3d04c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change triggers a change event for the parent model when the underlying collection changes, since it is akin to the key's contents changing. Views that listen to changes on a particular model don't have to listen to underlying collections as well to know if a model has fundamentally changed.