Skip to content

Add get_run method to SampleRegistry#49

Merged
Ulthran merged 1 commit into
masterfrom
codex/add-get_run-method-to-sampleregistry
Sep 12, 2025
Merged

Add get_run method to SampleRegistry#49
Ulthran merged 1 commit into
masterfrom
codex/add-get_run-method-to-sampleregistry

Conversation

@Ulthran
Copy link
Copy Markdown
Contributor

@Ulthran Ulthran commented Sep 12, 2025

Summary

  • expose a get_run method on SampleRegistry to fetch run records
  • cover get_run behavior with new tests

Testing

  • PYTHONPATH=app/sample_registry/src pytest -q

https://chatgpt.com/codex/tasks/task_e_68c3611b2d6883238d2c5743f6a10e36

Copilot AI review requested due to automatic review settings September 12, 2025 00:02
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 12, 2025

Codecov Report

❌ Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.12%. Comparing base (a41657a) to head (67b35e3).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...p/sample_registry/src/sample_registry/registrar.py 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   85.96%   86.12%   +0.15%     
==========================================
  Files          11       11              
  Lines         869      879      +10     
==========================================
+ Hits          747      757      +10     
  Misses        122      122              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a get_run method to the SampleRegistry class to fetch run records by accession number. The new method provides a more lenient alternative to the existing check_run_accession method by returning None instead of raising an exception when a run doesn't exist.

  • Adds get_run method that returns a Run object or None
  • Includes comprehensive test coverage for both successful retrieval and non-existent runs

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
app/sample_registry/src/sample_registry/registrar.py Adds the new get_run method with proper documentation
app/sample_registry/test/test_registrar.py Adds tests for both successful and unsuccessful run retrieval scenarios

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Ulthran Ulthran merged commit 934dacc into master Sep 12, 2025
9 of 10 checks passed
@Ulthran Ulthran deleted the codex/add-get_run-method-to-sampleregistry branch September 12, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants