Skip to content

Conversation

@Ulthran
Copy link
Contributor

@Ulthran Ulthran commented Sep 30, 2025

Summary

  • add a SampleRegistry.get_runs_by_data_uri helper that searches run data_uri values for a substring
  • exercise the new lookup in the registrar tests

Testing

  • pytest (fails: ModuleNotFoundError: No module named 'flask_sqlalchemy')

https://chatgpt.com/codex/tasks/task_e_68dc2158a6908323ad38e30e3ebf52d7

Copilot AI review requested due to automatic review settings September 30, 2025 18:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new method get_runs_by_data_uri to the SampleRegistry class that allows searching for runs by matching substrings within their data_uri field. The method returns a list of run accession numbers for matching runs.

  • Added SampleRegistry.get_runs_by_data_uri() method that searches run data_uri values for a substring
  • Added corresponding test coverage for the new method functionality

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
sample_registry/registrar.py Added new get_runs_by_data_uri method with proper documentation
tests/test_registrar.py Added test function to verify the new lookup functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Ulthran Ulthran merged commit 3c24871 into master Sep 30, 2025
6 of 7 checks passed
@Ulthran Ulthran deleted the codex/add-get_runs_by_data_uri-getter-function branch September 30, 2025 18:32
@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.34%. Comparing base (3d69a5b) to head (cf71cbd).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   64.24%   64.34%   +0.10%     
==========================================
  Files           8        8              
  Lines         702      704       +2     
==========================================
+ Hits          451      453       +2     
  Misses        251      251              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants