Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes Rubrik font binary files (.woff2) from version control and transitions to a local font hosting approach. The change updates font-face declarations in CSS from a single external URL to local font references with comprehensive weight and style variants, adds documentation for developers on how to place font files locally, and implements .gitignore rules to prevent font binaries from being committed.
Key Changes
- Replaced single external font URL with 14 local @font-face declarations covering font weights 200-800 in both normal and italic styles
- Added README.md with instructions for placing Rubrik font files in the local directory
- Created .gitignore to exclude .woff2 files from version control while preserving the README
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/static/styles.css | Expanded font declarations from single external URL to 14 local @font-face rules with comprehensive weight/style variants |
| app/static/fonts/rubrik/README.md | Documents required font file names and placement instructions for developers |
| app/static/fonts/rubrik/.gitignore | Ignores .woff2 binaries while allowing README.md to be tracked |
Comments suppressed due to low confidence (1)
app/static/styles.css:134
- The font-family "Rubrik-Regular" is redundant and duplicates the "Rubrik" font family with font-weight 400. The same font file (TPRubrik-Regular.woff2) is already defined in lines 48-54 under the "Rubrik" family. This duplication should be removed unless there is a specific reason to maintain a separate "Rubrik-Regular" family name.
@font-face {
font-family: "Rubrik-Regular";
src: url("/static/fonts/rubrik/TPRubrik-Regular.woff2") format("woff2");
font-weight: 400;
font-style: normal;
font-display: swap;
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Codex Task