Skip to content

Rename figures to follow fMRIPrep's convention#1062

Merged
tsalo merged 7 commits into
mainfrom
rename-figures
Jun 13, 2026
Merged

Rename figures to follow fMRIPrep's convention#1062
tsalo merged 7 commits into
mainfrom
rename-figures

Conversation

@tsalo

@tsalo tsalo commented Jun 11, 2026

Copy link
Copy Markdown
Member

Closes #969. Probably closes #947. Closes #1037.

Changes proposed in this pull request

Figure name changes

QSIPrep figure reportlets were renamed to follow the fMRIPrep/sMRIPrep convention of using standard BIDS entities plus a meaningful derivative suffix.

Old name pattern New name pattern
sub-*_summary.html sub-*_desc-summary_T1w.html, sub-*_desc-summary_T2w.html, or sub-*_desc-summary_dwi.html
sub-*_about.html sub-*_desc-about_T1w.html, sub-*_desc-about_T2w.html, or sub-*_desc-about_dwi.html
sub-*_conform.html sub-*_desc-conform_T1w.html or sub-*_desc-conform_T2w.html
sub-*_desc-seg_mask.svg sub-*_dseg.svg
sub-*_t1w2mni.svg sub-*_space-{template}_T1w.svg or sub-*_space-{template}_T2w.svg
sub-*_cohort-{N}_t1w2mni.svg sub-*_space-MNIInfant_cohort-{N}_T1w.svg or sub-*_space-MNIInfant_cohort-{N}_T2w.svg
sub-*_fmapreg.svg sub-*_desc-fmapCoreg_fieldmap.svg
sub-*_fmapregvsm.svg sub-*_desc-vsm_fieldmap.svg
sub-*_desc-sdc_b0.svg sub-*_desc-sdc_dwi.svg
sub-*_desc-sdcdrbuddi_b0.svg sub-*_desc-sdcdrbuddi_dwi.svg
sub-*_desc-sdcdrbuddi_b0t2w.svg sub-*_desc-sdcdrbuddiT2w_dwi.svg
sub-*_desc-sdc_fa.svg sub-*_desc-sdcFA_dwi.svg
sub-*_b0ref.svg sub-*_desc-b0ref_dwi.svg
sub-*_desc-resampled_b0ref.svg sub-*_desc-resampledb0ref_dwi.svg
sub-*_desc-shoreline_animation.gif sub-*_desc-shoreline_dwi.gif
sub-*_desc-{workflow}{N}_biascorr.svg sub-*_desc-biascorrpost{workflow}{N}_dwi.svg

@tsalo tsalo added the refactor Changes to the codebase that don't impact workflow inputs or outputs. label Jun 11, 2026
@codecov-commenter

codecov-commenter commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.37%. Comparing base (25a5919) to head (f50197e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1062      +/-   ##
==========================================
+ Coverage   47.33%   47.37%   +0.04%     
==========================================
  Files          66       66              
  Lines        9891     9899       +8     
  Branches     1098     1099       +1     
==========================================
+ Hits         4682     4690       +8     
  Misses       4978     4978              
  Partials      231      231              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsalo

tsalo commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

I processed complex-valued data locally with the figure check and it passed, so I am going to mark this as ready for review.

@tsalo tsalo marked this pull request as ready for review June 12, 2026 15:40
@tsalo tsalo requested a review from mattcieslak June 12, 2026 15:41
@tsalo tsalo merged commit e84d1f9 into main Jun 13, 2026
22 of 23 checks passed
@tsalo tsalo deleted the rename-figures branch June 13, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Changes to the codebase that don't impact workflow inputs or outputs.

Projects

None yet

2 participants