Rename figures to follow fMRIPrep's convention#1062
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1062 +/- ##
==========================================
+ Coverage 47.33% 47.37% +0.04%
==========================================
Files 66 66
Lines 9891 9899 +8
Branches 1098 1099 +1
==========================================
+ Hits 4682 4690 +8
Misses 4978 4978
Partials 231 231 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
I processed complex-valued data locally with the figure check and it passed, so I am going to mark this as ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #969. Probably closes #947. Closes #1037.
Changes proposed in this pull request
Figure name changes
QSIPrep figure reportlets were renamed to follow the fMRIPrep/sMRIPrep convention of using standard BIDS entities plus a meaningful derivative suffix.
sub-*_summary.htmlsub-*_desc-summary_T1w.html,sub-*_desc-summary_T2w.html, orsub-*_desc-summary_dwi.htmlsub-*_about.htmlsub-*_desc-about_T1w.html,sub-*_desc-about_T2w.html, orsub-*_desc-about_dwi.htmlsub-*_conform.htmlsub-*_desc-conform_T1w.htmlorsub-*_desc-conform_T2w.htmlsub-*_desc-seg_mask.svgsub-*_dseg.svgsub-*_t1w2mni.svgsub-*_space-{template}_T1w.svgorsub-*_space-{template}_T2w.svgsub-*_cohort-{N}_t1w2mni.svgsub-*_space-MNIInfant_cohort-{N}_T1w.svgorsub-*_space-MNIInfant_cohort-{N}_T2w.svgsub-*_fmapreg.svgsub-*_desc-fmapCoreg_fieldmap.svgsub-*_fmapregvsm.svgsub-*_desc-vsm_fieldmap.svgsub-*_desc-sdc_b0.svgsub-*_desc-sdc_dwi.svgsub-*_desc-sdcdrbuddi_b0.svgsub-*_desc-sdcdrbuddi_dwi.svgsub-*_desc-sdcdrbuddi_b0t2w.svgsub-*_desc-sdcdrbuddiT2w_dwi.svgsub-*_desc-sdc_fa.svgsub-*_desc-sdcFA_dwi.svgsub-*_b0ref.svgsub-*_desc-b0ref_dwi.svgsub-*_desc-resampled_b0ref.svgsub-*_desc-resampledb0ref_dwi.svgsub-*_desc-shoreline_animation.gifsub-*_desc-shoreline_dwi.gifsub-*_desc-{workflow}{N}_biascorr.svgsub-*_desc-biascorrpost{workflow}{N}_dwi.svg