Skip to content

Calculate smoothed ALFF from smoothed BOLD#1373

Open
tsalo wants to merge 14 commits into
mainfrom
smooth-alff
Open

Calculate smoothed ALFF from smoothed BOLD#1373
tsalo wants to merge 14 commits into
mainfrom
smooth-alff

Conversation

@tsalo

@tsalo tsalo commented Jan 29, 2025

Copy link
Copy Markdown
Member

Closes #1132. Reproduces #1124.

Changes proposed in this pull request

  • Pass smoothed, denoised BOLD into init_alff_wf and use that to calculate the smoothed ALFF instead of smoothing the ALFF image calculated from the unsmoothed BOLD data.
  • Pass the censored, denoised BOLD into init_alff_wf instead of using the interpolated data and censoring it within the workflow.

@tsalo tsalo added the breaking-change PRs that change results or interfaces. label Jan 29, 2025
@codecov

codecov Bot commented Jan 29, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 81.48148% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.96%. Comparing base (5c7821a) to head (9049944).
Report is 68 commits behind head on main.

Files with missing lines Patch % Lines
xcp_d/interfaces/restingstate.py 44.44% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1373      +/-   ##
==========================================
- Coverage   78.13%   77.96%   -0.17%     
==========================================
  Files          58       58              
  Lines        7248     7248              
  Branches      957      959       +2     
==========================================
- Hits         5663     5651      -12     
- Misses       1307     1321      +14     
+ Partials      278      276       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo requested a review from mattcieslak January 30, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change PRs that change results or interfaces.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calculate smoothed ALFF from smoothed BOLD

1 participant