Skip to content

Revert workbench to 1.5#1626

Merged
tsalo merged 2 commits into
mainfrom
revert-workbench
Jun 11, 2026
Merged

Revert workbench to 1.5#1626
tsalo merged 2 commits into
mainfrom
revert-workbench

Conversation

@tsalo

@tsalo tsalo commented Jun 11, 2026

Copy link
Copy Markdown
Member

Updating connectome-workbench to 2 broke the structure-specific figures in the executive summary.

Changes proposed in this pull request

  • Restored Workbench-based create_scenewise_pngs behavior by removing the pixi connectome-workbench-cli Qt6 dependency and installing pinned Ubuntu connectome-workbench=1.5.0-2 in Dockerfile.base.
  • Fixed executive-summary scene templating so both TX_IMG_* and T2_IMG_* placeholders are replaced.
  • Added a blank-image guard for ShowScene outputs so silent all-black Workbench renders fail clearly.
  • Fixed report generation when NiReports needs to normalize read-only SVG reportlets, and corrected traceback writing for report failures.
  • Added focused tests for scene placeholder replacement, blank image detection, and report failure handling.

@tsalo tsalo added bug Issues noting problems and PRs fixing those problems. dcan DCAN-related issues and PRs labels Jun 11, 2026
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "bash -lc 'if pixi lock --check; then echo '\"'\"'Lockfile up to date'\"'\"'; else pixi lock; fi'",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [
  "pixi.lock",
  "pyproject.toml"
 ],
 "outputs": [
  "pixi.lock"
 ],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 69.23077% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.64%. Comparing base (0974257) to head (a866022).

Files with missing lines Patch % Lines
xcp_d/reports/core.py 74.07% 3 Missing and 4 partials ⚠️
xcp_d/interfaces/workbench.py 63.63% 4 Missing ⚠️
xcp_d/interfaces/execsummary.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1626      +/-   ##
==========================================
- Coverage   82.65%   82.64%   -0.01%     
==========================================
  Files          58       58              
  Lines        7989     8026      +37     
  Branches     1123     1132       +9     
==========================================
+ Hits         6603     6633      +30     
- Misses       1043     1046       +3     
- Partials      343      347       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tsalo tsalo merged commit 498b3fc into main Jun 11, 2026
16 of 18 checks passed
@tsalo tsalo deleted the revert-workbench branch June 11, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issues noting problems and PRs fixing those problems. dcan DCAN-related issues and PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants