Add --censor-between parameter to censor short sets of nonoutliers between outliers - #1628
Merged
Conversation
Adds the CLI argument, the config.workflow field, and placeholder TODOs marking where the temporal-mask expansion will go. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
--censor-between is required in 'none' mode, so test_ds001419_nifti failed parameter validation. Set to 0 to preserve existing behavior. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1628 +/- ##
==========================================
+ Coverage 82.64% 83.19% +0.55%
==========================================
Files 58 58
Lines 8026 8094 +68
Branches 1132 1137 +5
==========================================
+ Hits 6633 6734 +101
+ Misses 1046 1014 -32
+ Partials 347 346 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
@LuciMoore @madisoth does this do what you need? |
Collaborator
|
Just got around to testing this and it just needs to also have the censoring applied to the masks in the ABCC QC hdf5 file (and the remaining frames, mean FD, etc. to reflect the extra censoring) -- the rest looks all good to me. |
Member
Author
|
@madisoth I made the change you requested and have released 26.2.0rc1. Can you test it out to make sure it does what you want before I release 26.2.0? |
Collaborator
|
looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes none, but relates to #724 and #1159.
--censor-between Ncensors any contiguous segment of non-outlier volumes of length N or fewer. Default is 0 in every mode (for now).Changes proposed in this pull request
censor_between_outliers.ExpandTemporalMask.censor_betweenanddenoising(the union offramewise_displacementandcensor_between.