compute_plxpr_decomposition for StronglyEntanglingLayers, Grover, QFT
#6917
+189
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
…ennylane into cond_dynamic_decomp_ops
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## multi_level_decomp #6917 +/- ##
====================================================
Coverage 99.59% 99.59%
====================================================
Files 481 482 +1
Lines 45870 46145 +275
====================================================
+ Hits 45685 45960 +275
Misses 185 185 ☔ View full report in Codecov by Sentry. |
albi3ro
reviewed
Feb 20, 2025
There was a problem hiding this comment.
Thanks @josephleekl ! LGTM
I have a few other comments/questions but we can chat in person 🚀
tests/capture/transforms/test_capture_dynamic_decompositions.py
Outdated
Show resolved
Hide resolved
tests/capture/transforms/test_capture_dynamic_decompositions.py
Outdated
Show resolved
Hide resolved
josephleekl
changed the title
compute_plxpr_decomposition for StronglyEntanglingLayers, Grover, QFT
| @partial(qml.transforms.decompose, max_expansion=max_expansion, gate_set=gate_set) | ||
| @qml.qnode(device=qml.device("default.qubit", wires=n_wires), autograph=False) | ||
| def circuit_comparison(): | ||
| qml.StronglyEntanglingLayers(weights, wires=range(n_wires), imprimitive=imprimitive) |
There was a problem hiding this comment.
As discussed on Slack, we could also test the explicit structure of the jaxpr to ensure that the logic for max_expansion and gate_set is correct 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
test directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
doc/releases/changelog-dev.mdfile, summarizing thechange, and including a link back to the PR.
The PennyLane source code conforms to
PEP8 standards.
We check all of our code against Pylint.
To lint modified files, simply
pip install pylint, and thenrun
pylint pennylane/path/to/file.py.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
This PR adds the implementation of
compute_plxpr_decompositionto following operators:This PR extends the work here, which adds support to capturing control-flow in decomposition, including nested decomposition.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-81818]