[Capture] Switch from binding qnode_kwargs to execution_config
#6991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albi3ro
commented
Feb 21, 2025
albi3ro
commented
Feb 21, 2025
…yLaneAI/pennylane into qnode-prim-execution-config
andrijapau
reviewed
Feb 21, 2025
andrijapau
reviewed
Feb 21, 2025
Comment on lines
133
to
138
| expected_config = qml.devices.ExecutionConfig( | ||
| gradient_method="best", | ||
| gradient_keyword_arguments={}, | ||
| use_device_jacobian_product=False, | ||
| interface="jax", | ||
| ) |
There was a problem hiding this comment.
Could we also use construct_execution_config here?
There was a problem hiding this comment.
Using it in the source code, but just being a bit more manual in the tests.
mudit2812
reviewed
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
As the capture workflow is getting more complicated, we should start using the well-defined
ExecutionConfigobject instead of the ambiguous and unspecifiedqnode_kwargs.We also need to start passing the
execution_configto the device, as that information is needed for handling mid circuit measurements.Description of the Change:
Switches from binding a
qnode_kwargsdictionary to anexecution_configobject.Benefits:
Easier to manage the configuration of a workflow. Can specify MCM configuration info for device execution.
Possible Drawbacks:
Technically a breaking change, but a breaking change to an experimental project.
Related GitHub Issues:
[sc-84916]