Add the music provider seam behind the Tidal shim - #11
Draft
chrispmonkey wants to merge 2 commits into
Draft
Conversation
The music experience is itself a Tidal client, so a hook rewrites its api.tidal.com REST host to this server and stubs the session token, and the server answers the play-music chain (search, tracks, playbackinfo) with a local test tone. No external providers yet — this is the shim the provider work plugs in behind.
Introduce a MusicProvider trait (search, queue, track, recommendations, playback) and a built-in mock that plays the local test tone, and drive the shim off Arc<dyn MusicProvider> instead of canned data. A new source is now a new impl in its own file selected by [music] provider — the shim and core server files never change to add one.
chrispmonkey
force-pushed
the
pr2-provider-seam
branch
from
August 13, 2026 23:16
14ced71 to
1f117d9
Compare
Member
|
Rebase after merge So you're aware, you can use stacked PRs now in GitHub, and I generally recommend people do not force push to PRs as it is difficult to review the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on #8. The Tidal-mock shim from #8 now resolves tracks through a
MusicProvidertrait instead of hardcoding the test tone, so real providersslot in behind a single seam.
Adds
server-rs/src/music/(theMusicProvidertrait + aMockProviderreference impl), a
[music] providerconfig key, and refactorstidal_shim.rsto drive off the provider. Only the mock exists today; each real provider lands
as its own PR.
The reviewable delta is
server-rs/src/music/*and thetidal_shim.rsrefactor— the rest of the diff is #8 (already approved) and collapses to just the seam
once #8 merges. Draft until then.