Conversation
added SSD1306 I2C version fix build_test.sh update README.md
|
@enelson1001 Hey. I'm on vacation for another week, I'll have look at this afterwards. |
|
Looks good, just wonder if all the changes in sdkonfig are just default values for a newer IDF? |
|
Must be because I did not make changes to that file. |
| - ILI9341 | ||
| - ST7735 | ||
| - SH1107 | ||
| - SSD1306(I2C) |
There was a problem hiding this comment.
If this is a I2C device, then lets place it under the I2C section. Maybe we should reorganize the entire tree based on type instead of protocol type....
There was a problem hiding this comment.
Are you saying do something like this
spi
|- display
| - sensors
i2c
|- display
| sensors
etc?
|
Yes, don't you think that is more organised that the current list?
…On Wed, 11 Aug 2021, 05:04 enelson1001, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In README.md
<#163 (comment)>:
> @@ -64,12 +64,14 @@ If you are working on Windows or you don't want to install the dependencies on y
- ILI9341
- ST7735
- SH1107
+ - SSD1306(I2C)
Are you saying do something like this
spi
|- display
| - sensors
i2c
|- display
| sensors
etc?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#163 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAU2LLAOREOY5DYQE23AOHLT4HSD5ANCNFSM5ARG2WMQ>
.
|
|
Yes that does sound better. |
|
|
I will start looking at what is involved to make this change this weekend. I will probably have a few more comments. |
|
Per thanks |
added SSD1306 I2C version
fix build_test.sh
update README.md