we aren't going to run late INIT blocks, so don't save them #23219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was looking over Perl#1674, where it was suggested that late INIT blocks behave like BEGIN, and Larry approved of that (25 years ago). But history has moved on, we have 25 years of code developed under the current behaviour of INIT and I suspect such a change is more likely to break existing code than fix anything. But looking at the code in S_process_special_blocks() we do still push the CV onto PL_initav, even though that CV will never be called. So don't push the CV if it's too late to call it.
jkeenan
added
the
defer-next-dev
|
We can begin to discuss this p.r., but due to code freeze cannot merge it until the 5.43 development cycle starts. Hence, I've labelled this "defer-next-dev." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking over #1674, where it was suggested that late INIT blocks behave like BEGIN, and Larry approved of that (25 years ago).
But history has moved on, we have 25 years of code developed under the current behaviour of INIT and I suspect such a change is more likely to break existing code than fix anything.
But looking at the code in S_process_special_blocks() we do still push the CV onto PL_initav, even though that CV will never be called.
So don't push the CV if it's too late to call it.