embed.fnc: Rename EPTR qualifiers #23997
Open
+104
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People found the former names confusing. This changes to use EPTRgt and EPTRge that explicitly give the relation that gets used.
tonycoz
reviewed
Dec 10, 2025
Comment on lines
+209
to
+213
| : EPTRge means that not only must this pointer parameter be non-NULL, it | ||
| : points to the final character of the string that a corresponding | ||
| : SPTR began and/or MPTR points to the middle of. The called | ||
| : function is not to look at any byte beyond this one. This means | ||
| : the string may be empty. |
Contributor
There was a problem hiding this comment.
This doesn't seem right.
As I read this, for the string "ABCD" the EPTRge tagged pointer would point at the "D" , "it points to the final character of the string" and that "D" is included in the string to be processed.
"The called function is not to look at any byte beyond this one" implies they can deref the EPTRge tagged pointer (but not any beyond that) which indicates the same.
Maybe:
it points immediately past the final character of the string that ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People found the former names confusing. This changes to use EPTRgt and EPTRge that explicitly give the relation that gets used.