Skip to content

Per saving or viewing tags fails #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025

Conversation

crisnicandrei
Copy link
Contributor

@crisnicandrei crisnicandrei commented May 9, 2025

Steps to test:
Upload a record
Add a tag
It should display the tag

Make keywords work again on records prior to changing to the new get/v2 api call
@crisnicandrei crisnicandrei force-pushed the PER-saving-or-viewing-tags-fails branch from 4fd26b8 to 22184bb Compare May 9, 2025 12:13
@crisnicandrei crisnicandrei requested review from slifty and liam-lloyd May 9, 2025 12:13
Copy link

codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 62.22222% with 17 lines in your changes missing coverage. Please review.

Project coverage is 44.51%. Comparing base (99798f4) to head (22184bb).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/app/core/services/tags/tags.service.ts 47.05% 7 Missing and 2 partials ⚠️
...rowser/components/edit-tags/edit-tags.component.ts 65.21% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
- Coverage   44.56%   44.51%   -0.05%     
==========================================
  Files         370      370              
  Lines       11290    11311      +21     
  Branches     1850     1862      +12     
==========================================
+ Hits         5031     5035       +4     
- Misses       6092     6103      +11     
- Partials      167      173       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@slifty slifty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concerns around our typing apply here, but similarly to other PRs I don't think that is in scope of solving this problem.

Let's make sure this passes QA, and then we can regroup to talk about the future of typing and API integration.

@crisnicandrei crisnicandrei requested a review from k8lyn6 May 14, 2025 16:07
Copy link

@k8lyn6 k8lyn6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to fix the issue! Checked existing files with existing keywords and custom metadata, as well as existing files that did not have keywords/custom metadata, and uploaded a new file to test with as well. All tests worked. :)

@crisnicandrei crisnicandrei merged commit 7ae661f into main May 14, 2025
9 checks passed
@crisnicandrei crisnicandrei deleted the PER-saving-or-viewing-tags-fails branch May 14, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants