-
Notifications
You must be signed in to change notification settings - Fork 1
PER-10188-location-not-displaying #566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #566 +/- ##
==========================================
+ Coverage 44.57% 44.87% +0.30%
==========================================
Files 370 370
Lines 11317 11319 +2
Branches 1865 1865
==========================================
+ Hits 5044 5079 +35
+ Misses 6100 6067 -33
Partials 173 173 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7458c00
to
1626124
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for setting a new location! I'm able to set a location and it remains correct when refreshed. Previously uploaded files that already had an existing location also are showing up correctly now (yay!).
However, all the previously uploaded files that did not have a location show a google maps error when I look at the metadata (see attached). Could you investigate, Andrei? It seems like this was introduced in this PR as I don't think this issue is happening on prod currently.
770c8e3
to
e2fdbc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay this morning! This fixed the issue with the map showing up when there was no location. Thanks @crisnicandrei !
Display locations for records after the v2 change
Remove locnId before updating the item
hide map if there is no location
e2fdbc4
to
0647ba2
Compare
Display locations for records after the v2 change
@slifty heads up I did not remove LocnVOs yet from the codebase because the profile also has them :)