Skip to content

PER-10188-location-not-displaying #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2025

Conversation

crisnicandrei
Copy link
Contributor

Display locations for records after the v2 change

@slifty heads up I did not remove LocnVOs yet from the codebase because the profile also has them :)

Copy link

codecov bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 44.87%. Comparing base (d1cc4f3) to head (0647ba2).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/app/shared/pipes/pr-location.pipe.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #566      +/-   ##
==========================================
+ Coverage   44.57%   44.87%   +0.30%     
==========================================
  Files         370      370              
  Lines       11317    11319       +2     
  Branches     1865     1865              
==========================================
+ Hits         5044     5079      +35     
+ Misses       6100     6067      -33     
  Partials      173      173              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@crisnicandrei crisnicandrei force-pushed the PER-10188-locations-not-displaying branch 2 times, most recently from 7458c00 to 1626124 Compare May 14, 2025 14:12
@k8lyn6 k8lyn6 self-requested a review May 14, 2025 16:05
Copy link

@k8lyn6 k8lyn6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for setting a new location! I'm able to set a location and it remains correct when refreshed. Previously uploaded files that already had an existing location also are showing up correctly now (yay!).

However, all the previously uploaded files that did not have a location show a google maps error when I look at the metadata (see attached). Could you investigate, Andrei? It seems like this was introduced in this PR as I don't think this issue is happening on prod currently.
Screenshot 2025-05-14 at 3 16 38 PM

@crisnicandrei crisnicandrei force-pushed the PER-10188-locations-not-displaying branch from 770c8e3 to e2fdbc4 Compare May 14, 2025 21:55
@crisnicandrei crisnicandrei requested a review from k8lyn6 May 14, 2025 21:56
Copy link

@k8lyn6 k8lyn6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay this morning! This fixed the issue with the map showing up when there was no location. Thanks @crisnicandrei !

Display locations for records after the v2 change
Remove locnId before updating the item
hide map if there is no location
@crisnicandrei crisnicandrei force-pushed the PER-10188-locations-not-displaying branch from e2fdbc4 to 0647ba2 Compare May 15, 2025 18:51
@crisnicandrei crisnicandrei merged commit 6d51aac into main May 15, 2025
4 checks passed
@crisnicandrei crisnicandrei deleted the PER-10188-locations-not-displaying branch May 15, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants