Skip to content

Minus Button sensitivity depends on row items #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Minus Button sensitivity depends on row items #179

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e176394
Merge pull request #1 from Philip-Scott/master
snowparrot Aug 30, 2017
9d460c3
- If one the selected rows is in the trash minus_button is disabled
snowparrot Aug 30, 2017
1a778cf
add Icons
snowparrot Aug 30, 2017
fab7e4d
prepare for first push request
snowparrot Aug 30, 2017
650b904
code style
snowparrot Aug 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 24 additions & 5 deletions src/Widgets/PagesList.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,11 +272,30 @@ public class ENotes.PagesList : Gtk.Box {
refresh ();
});

listbox.row_selected.connect ((row) => {
if (row == null || loading_pages) return;
minus_button.set_sensitive (true);
ENotes.ViewEditStack.get_instance ().set_page (((ENotes.PageItem) row).page, false);
});
listbox.row_selected.connect ((last_selected_row) => {
if (last_selected_row == null || loading_pages) return;

var rows = listbox.get_selected_rows ();

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra white-space line

bool all_trashed = true;
bool all_not_trashed = true;

foreach (var row in rows) {
var pagerow = ((ENotes.PageItem) row).page;
var page_trashed = Trash.get_instance ().is_page_trashed (pagerow);

all_trashed = all_trashed && page_trashed;
all_not_trashed = all_not_trashed && !page_trashed;
}
if (all_not_trashed) {
minus_button.set_sensitive (true);
}
else {
minus_button.set_sensitive (false);
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can replace all of this for minus_button.set_sensitive (all_not_trashed)


ENotes.ViewEditStack.get_instance ().set_page (((ENotes.PageItem) last_selected_row).page, false);
});

listbox.row_activated.connect ((row) => {
window.toggle_edit ();
Expand Down