Skip to content

Conversation

@mjansen4857
Copy link
Contributor

@mjansen4857 mjansen4857 commented Oct 17, 2025

Description

Adds support for building images for the Luma P1. This bumps the image modifier pin to v2025.0.4. This pulls in:

Move compression outside of mount script (https://github.com/PhotonVision/photon-image-modifier/pull/84[)](https://github.com/PhotonVision/photon-image-modifier/commit/224a35cd3f714801402b73c389f5b00c5fd6e3c5)
Add Luma P1 support (https://github.com/PhotonVision/photon-image-modifier/pull/85[)](https://github.com/PhotonVision/photon-image-modifier/commit/cd928224b86600f5eb6fd2ff92ca88474c647815)
Fix tarball directory structure (https://github.com/PhotonVision/photon-image-modifier/pull/86[)](https://github.com/PhotonVision/photon-image-modifier/commit/970f1b585696d672a3f09d20d2c021fd924e577f)

Full Changelog: PhotonVision/photon-image-modifier@v2026.0.3...v2026.0.4

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@samfreund
Copy link
Member

@mjansen4857 new version is cut over at https://github.com/photonvision/photon-image-modifier, if you want to bump that to v2026.0.4 here and test, we can go ahead and get this merged.

@mjansen4857 mjansen4857 marked this pull request as ready for review October 21, 2025 04:42
@mjansen4857 mjansen4857 requested a review from a team as a code owner October 21, 2025 04:42
@mjansen4857
Copy link
Contributor Author

Alright should be all set

Copy link
Member

@spacey-sooty spacey-sooty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add a hardware config? Otherwise looks reasonable

@mjansen4857
Copy link
Contributor Author

There's a hardware config in the database installed in the image modifier.

@samfreund samfreund dismissed their stale review October 21, 2025 16:55

image version has been bumped

@mcm001 mcm001 merged commit ee4501f into PhotonVision:main Oct 21, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants