Skip to content

Conversation

@james-kwong
Copy link

@james-kwong james-kwong commented Sep 29, 2025

Photonvision OBB Demo

Support YoloV11 OBB detection. Not sure if there's a better way to do it then to change the NeuralNetworkPipelineResult to use rotated rectangles so that's what I did.

Corresponding Photonvision PR: PhotonVision/photonvision#2105

@samfreund
Copy link
Member

Lint please 😄

@mcm001
Copy link
Collaborator

mcm001 commented Sep 29, 2025

Changing to be a rotated rectangle seems reasonable

@@ -0,0 +1 @@
cage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need the labels file?

Copy link
Author

@james-kwong james-kwong Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that if someone wanted to test the provided OBB model that having the labels file would be useful.

Edit: Fair enough, in the code it shows numClasses = 0 so it should be intuitive

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My other reasoning is that we don't use labels in the main repo, so having one here could be confusing. We can add a comment to the test code perhaps, but iirc the name of the class doesn't really matter except for human facing stuff. It could just as easily be named foo.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Thank you Sam!

@james-kwong
Copy link
Author

Lint please 😄

Yes, I will do that soon, thank you for reminding me 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants