-
Couldn't load subscription status.
- Fork 7
Add YoloV11 OBB #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add YoloV11 OBB #28
Conversation
|
Lint please 😄 |
|
Changing to be a rotated rectangle seems reasonable |
| @@ -0,0 +1 @@ | |||
| cage | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't need the labels file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking that if someone wanted to test the provided OBB model that having the labels file would be useful.
Edit: Fair enough, in the code it shows numClasses = 0 so it should be intuitive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My other reasoning is that we don't use labels in the main repo, so having one here could be confusing. We can add a comment to the test code perhaps, but iirc the name of the class doesn't really matter except for human facing stuff. It could just as easily be named foo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Thank you Sam!
Yes, I will do that soon, thank you for reminding me 😊 |
Support YoloV11 OBB detection. Not sure if there's a better way to do it then to change the NeuralNetworkPipelineResult to use rotated rectangles so that's what I did.
Corresponding Photonvision PR: PhotonVision/photonvision#2105