spi.close() does not remove the ID from the Context. Not sure how th…#677
Merged
Conversation
… context rework created this, calling super.close() fixed it. Maybe Stefan will understand the previous code path that did the removel.
stefanhaustein
approved these changes
Jun 24, 2026
Contributor
|
(I suspect it never worked and cleaning up a supposedly redundant shutdown call somewhere exposed this)? |
FDelporte
reviewed
Jun 24, 2026
| @Override | ||
| public void close() { | ||
| logger.trace("invoked 'closed()'"); | ||
| super.close(); |
Contributor
There was a problem hiding this comment.
IIRC I had fixed this a while ago for I2c but did not check SPI:
I had noticed while working on the USB bridge, which supports I2C only...
I guess it might be cleaner to call super.close there, too
Member
|
@stefanhaustein will you change it in SPI then? |
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e context rework created this, calling super.close() fixed it. Maybe Stefan will understand the previous code path that did the removel.